Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 2917183003: update the analyzer and analysis server perf tags (Closed)
Patch Set: updates for review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 546859f79381a13a9be471321679340aa3c4446a..647211c5b7de461cbca9c6555673456a47cc88f5 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -1092,7 +1092,7 @@ class AnalysisServer {
*/
void performOperation() {
assert(performOperationPending);
- PerformanceTag.UNKNOWN.makeCurrent();
+ PerformanceTag.unknown.makeCurrent();
performOperationPending = false;
if (!running) {
// An error has occurred, or the connection to the client has been
@@ -2343,6 +2343,11 @@ class ServerPerformance {
*/
class ServerPerformanceStatistics {
/**
+ * The [PerformanceTag] for `package:analysis_server`.
+ */
+ static PerformanceTag server = new PerformanceTag('server');
+
+ /**
* The [PerformanceTag] for time spent in [ExecutionDomainHandler].
*/
static PerformanceTag executionNotifications =
@@ -2369,22 +2374,22 @@ class ServerPerformanceStatistics {
* The [PerformanceTag] for time spent in
* PerformAnalysisOperation._sendNotices.
*/
- static PerformanceTag notices = new PerformanceTag('notices');
+ static PerformanceTag notices = server.createChild('notices');
/**
* The [PerformanceTag] for time spent running pub.
*/
- static PerformanceTag pub = new PerformanceTag('pub');
+ static PerformanceTag pub = server.createChild('pub');
/**
* The [PerformanceTag] for time spent in server communication channels.
*/
- static PerformanceTag serverChannel = new PerformanceTag('serverChannel');
+ static PerformanceTag serverChannel = server.createChild('channel');
/**
* The [PerformanceTag] for time spent in server request handlers.
*/
- static PerformanceTag serverRequests = new PerformanceTag('serverRequests');
+ static PerformanceTag serverRequests = server.createChild('requests');
/**
* The [PerformanceTag] for time spent in split store microtasks.
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_manager.dart » ('j') | pkg/analyzer/lib/source/pub_package_map_provider.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698