update the analyzer and analysis server perf tags

pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/context/declared_variables.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/error/listener.dart';
@@ skipping 42 matching lines @@
   final Map<FileState, List<PendingError>> _fileToPendingErrors = {};
   final List<ConstantEvaluationTarget> _constants = [];
 
   LibraryAnalyzer(this._analysisOptions, this._declaredVariables,
       this._sourceFactory, this._fsState, this._store, this._library);
 
   /**
    * Compute analysis results for all units of the library.
    */
   Map<FileState, UnitAnalysisResult> analyze() {
+    return PerformanceStatistics.analysis.makeCurrentWhile(() {
+      return _analyze();
+    });
+  }
+
+  Map<FileState, UnitAnalysisResult> _analyze() {
     Map<FileState, CompilationUnit> units = {};
 
     // Parse all files.
-    units[_library] = _parse(_library);
-    for (FileState part in _library.partedFiles) {
-      units[part] = _parse(part);
-    }
+    PerformanceStatistics.parse.makeCurrentWhile(() {
+      units[_library] = _parse(_library);

[scheglov, 2017/06/04 00:30:44]

Most of the work of _parse() is in FileState.parse(), which should be
instrumented.

[devoncarew, 2017/06/04 01:45:52]

I moved the instrumentation there.

+      for (FileState part in _library.partedFiles) {
+        units[part] = _parse(part);
+      }
+    });
 
     // Resolve URIs in directives to corresponding sources.
     units.forEach((file, unit) {
       _resolveUriBasedDirectives(file, unit);
     });
 
     _createAnalysisContext();
 
     try {
       _resynthesizer = new StoreBasedSummaryResynthesizer(
           _context, _sourceFactory, _analysisOptions.strongMode, _store);
       _typeProvider = _resynthesizer.typeProvider;
       _context.typeProvider = _typeProvider;
 
       _libraryElement = _resynthesizer.getLibraryElement(_library.uriStr);
 
       _resolveDirectives(units);
 
       units.forEach((file, unit) {
         _resolveFile(file, unit);
         _computePendingMissingRequiredParameters(file, unit);
       });
 
       _computeConstants();
 
-      units.forEach((file, unit) {
-        _computeVerifyErrors(file, unit);
+      PerformanceStatistics.errors.makeCurrentWhile(() {
+        units.forEach((file, unit) {
+          _computeVerifyErrors(file, unit);
+        });
       });
 
       if (_analysisOptions.hint) {
-        units.forEach((file, unit) {
-          {
-            var visitor = new GatherUsedLocalElementsVisitor(_libraryElement);
-            unit.accept(visitor);
-            _usedLocalElementsList.add(visitor.usedElements);
-          }
-          {
-            var visitor =
-                new GatherUsedImportedElementsVisitor(_libraryElement);
-            unit.accept(visitor);
-            _usedImportedElementsList.add(visitor.usedElements);
-          }
-        });
-        units.forEach((file, unit) {
-          _computeHints(file, unit);
+        PerformanceStatistics.hints.makeCurrentWhile(() {
+          units.forEach((file, unit) {
+            {
+              var visitor = new GatherUsedLocalElementsVisitor(_libraryElement);
+              unit.accept(visitor);
+              _usedLocalElementsList.add(visitor.usedElements);
+            }
+            {
+              var visitor =
+                  new GatherUsedImportedElementsVisitor(_libraryElement);
+              unit.accept(visitor);
+              _usedImportedElementsList.add(visitor.usedElements);
+            }
+          });
+          units.forEach((file, unit) {
+            _computeHints(file, unit);
+          });
         });
       }
 
       if (_analysisOptions.lint) {
-        units.forEach((file, unit) {
-          _computeLints(file, unit);
+        PerformanceStatistics.lints.makeCurrentWhile(() {
+          units.forEach((file, unit) {
+            _computeLints(file, unit);
+          });
         });
       }
     } finally {
       _context.dispose();
     }
 
     // Return full results.
     Map<FileState, UnitAnalysisResult> results = {};
     units.forEach((file, unit) {
       List<AnalysisError> errors = _getErrorListener(file).errors;
@@ skipping 653 matching lines @@
 }
 
 /**
  * Either the name or the source associated with a part-of directive.
  */
 class _NameOrSource {
   final String name;
   final Source source;
   _NameOrSource(this.name, this.source);
 }