Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2917133002: Perform redirect checks before OnReceivedRedirect in //net. (Closed)
Patch Set: mmenke comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
index 80adea69abf40ba8baa319e938ea135276deeaed..098419a7b70ae18bea0a873254e2cd2280d85b69 100644
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
@@ -6861,11 +6861,14 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
// The expectation is that about:blank was loaded and the virtual URL is set
// to the URL that was blocked.
+ //
+ // TODO(nasko): Now that the error commits on the previous URL, the blocked
+ // navigation logic is no longer needed.
EXPECT_EQ(1, controller.GetLastCommittedEntryIndex());
EXPECT_FALSE(
controller.GetLastCommittedEntry()->GetURL().SchemeIs(url::kDataScheme));
- EXPECT_TRUE(controller.GetLastCommittedEntry()->GetVirtualURL().SchemeIs(
- url::kDataScheme));
+ EXPECT_EQ(redirect_to_blank_url,
nasko 2017/06/06 00:27:38 Let's rename this, redirect_to_unsafe_redirect is
davidben 2017/06/06 17:31:08 Done.
+ controller.GetLastCommittedEntry()->GetVirtualURL());
EXPECT_EQ(url::kAboutBlankURL,
controller.GetLastCommittedEntry()->GetURL().spec());
}

Powered by Google App Engine
This is Rietveld 408576698