Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: ash/public/cpp/shelf_model_observer.h

Issue 2917013002: mash: Move ShelfModel* to ash/public/cpp. (Closed)
Patch Set: Initialize the AppList item title in ShelfController. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/public/cpp/shelf_model_observer.h
diff --git a/ash/shelf/shelf_model_observer.h b/ash/public/cpp/shelf_model_observer.h
similarity index 79%
rename from ash/shelf/shelf_model_observer.h
rename to ash/public/cpp/shelf_model_observer.h
index ca8f405434a81ba7c7ee2569eaa1e64b4c3bfc2d..581d9f1a5214b6d37501fb394c32445e826204ef 100644
--- a/ash/shelf/shelf_model_observer.h
+++ b/ash/public/cpp/shelf_model_observer.h
@@ -2,10 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef ASH_SHELF_SHELF_MODEL_OBSERVER_H_
-#define ASH_SHELF_SHELF_MODEL_OBSERVER_H_
+#ifndef ASH_PUBLIC_CPP_SHELF_MODEL_OBSERVER_H_
+#define ASH_PUBLIC_CPP_SHELF_MODEL_OBSERVER_H_
-#include "ash/ash_export.h"
+#include "ash/public/cpp/ash_public_export.h"
#include "ash/public/cpp/shelf_types.h"
namespace ash {
@@ -13,8 +13,8 @@ namespace ash {
struct ShelfItem;
class ShelfItemDelegate;
-// TODO(msw): Move this to ash/public/cpp and use ASH_PUBLIC_EXPORT.
-class ASH_EXPORT ShelfModelObserver {
+// An observer interface for shelf item and delegate changes in ShelfModel.
+class ASH_PUBLIC_EXPORT ShelfModelObserver {
public:
// Invoked after an item has been added to the model.
virtual void ShelfItemAdded(int index) = 0;
@@ -40,4 +40,4 @@ class ASH_EXPORT ShelfModelObserver {
} // namespace ash
-#endif // ASH_SHELF_SHELF_MODEL_OBSERVER_H_
+#endif // ASH_PUBLIC_CPP_SHELF_MODEL_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698