Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6712)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2916933002: Re-commit "win: Set is_clang=true by default" over the weekend. (Closed)
Patch Set: third_party/WebKit/Tools/Scripts/webkit-patch rebaseline-cl Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index fb8514f174b95a9420458498ad02ea291f3e3b83..52b950279bfb4b2368b9f0e0007b9f8844d9e1b0 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -1813,10 +1813,14 @@ class DevToolsReattachAfterCrashTest : public DevToolsSanityTest {
}
};
+// TODO(hans): Temporarily disable while enabling Clang by default on Windows
+// over the weekend. (crbug.com/727458)
+#if !(defined(OS_WIN) && defined(__clang__))
IN_PROC_BROWSER_TEST_F(DevToolsReattachAfterCrashTest,
TestReattachAfterCrashOnTimeline) {
RunTestWithPanel("timeline");
}
+#endif
IN_PROC_BROWSER_TEST_F(DevToolsReattachAfterCrashTest,
TestReattachAfterCrashOnNetwork) {
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698