Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2916923002: Update a few more methods in FixProcessor, and fix some bugs in ChangeBuilder (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update a few more methods in FixProcessor, and fix some bugs in ChangeBuilder R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b5c630426ce3e9785db9ca7bf302d34105893229

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -243 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 16 chunks +182 lines, -189 lines 2 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart View 18 chunks +77 lines, -52 lines 0 comments Download
M pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-01 16:43:16 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2916923002/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right): https://codereview.chromium.org/2916923002/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart#newcode1748 pkg/analysis_server/lib/src/services/correction/fix_internal.dart:1748: builder.addInsertion(insertOffset, (DartEditBuilder builder) { addSimpleInsertion() here and in ...
3 years, 6 months ago (2017-06-01 16:57:51 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2916923002/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right): https://codereview.chromium.org/2916923002/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart#newcode1748 pkg/analysis_server/lib/src/services/correction/fix_internal.dart:1748: builder.addInsertion(insertOffset, (DartEditBuilder builder) { Done
3 years, 6 months ago (2017-06-01 22:30:29 UTC) #4
Brian Wilkerson
3 years, 6 months ago (2017-06-02 14:36:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b5c630426ce3e9785db9ca7bf302d34105893229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698