pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart - Issue 2916893002: Handle int constant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

Issue 2916893002: Handle int constant (Closed)

Patch Set: Updated cf. comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder/collector.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart b/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

index 15dc23a6381b6eab46f7abc8e304d46142bf44e3..a3e64d4c79b614d4a0010b20eb38a386ef9d31aa 100644

--- a/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

@@ -13,8 +13,6 @@ import '../elements/types.dart' show InterfaceType;

import '../js/js.dart' as jsAst;

import '../js/js.dart' show js;

import '../js_backend/namer.dart' show Namer;

-import '../js_backend/constant_handler_javascript.dart'

- show JavaScriptConstantCompiler;

import '../js_backend/custom_elements_analysis.dart'

show CustomElementsCodegenAnalysis;

import '../js_backend/native_data.dart';

@@ -32,7 +30,6 @@ class InterceptorStubGenerator {

final CommonElements _commonElements;

final CodeEmitterTask _emitterTask;

final NativeCodegenEnqueuer _nativeCodegenEnqueuer;

- final JavaScriptConstantCompiler _constants;

final Namer _namer;

final OneShotInterceptorData _oneShotInterceptorData;

final CustomElementsCodegenAnalysis _customElementsCodegenAnalysis;

@@ -44,7 +41,6 @@ class InterceptorStubGenerator {

this._commonElements,

this._emitterTask,

this._nativeCodegenEnqueuer,

- this._constants,

this._namer,

this._oneShotInterceptorData,

this._customElementsCodegenAnalysis,

@@ -417,7 +413,7 @@ class InterceptorStubGenerator {

List<jsAst.Expression> elements = <jsAst.Expression>[];

List<ConstantValue> constants =

- _constants.getConstantsForEmission(_emitter.compareConstants);

+ _codegenWorldBuilder.getConstantsForEmission(_emitter.compareConstants);

for (ConstantValue constant in constants) {

if (constant is TypeConstantValue &&

constant.representedType is InterfaceType) {