Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #include "chrome/browser/translate/chrome_translate_client.h" | |
| 6 | |
| 7 #include <memory> | |
| 8 | |
| 9 #include "base/command_line.h" | |
| 10 #include "base/memory/ref_counted.h" | |
| 11 #include "base/run_loop.h" | |
| 12 #include "chrome/browser/sync/profile_sync_service_factory.h" | |
| 13 #include "chrome/browser/sync/user_event_service_factory.h" | |
| 14 #include "chrome/test/base/chrome_render_view_host_test_harness.h" | |
| 15 #include "components/sync/user_events/fake_user_event_service.h" | |
| 16 #include "components/translate/core/common/language_detection_details.h" | |
| 17 #include "content/public/browser/web_contents.h" | |
| 18 #include "testing/gtest/include/gtest/gtest.h" | |
| 19 #include "url/gurl.h" | |
| 20 | |
| 21 std::unique_ptr<KeyedService> BuildFakeUserEventService( | |
| 22 content::BrowserContext* context) { | |
| 23 return base::MakeUnique<syncer::FakeUserEventService>(); | |
| 24 } | |
| 25 | |
| 26 class ChromeTranslateClientTest : public ChromeRenderViewHostTestHarness { | |
| 27 public: | |
| 28 void SetUp() override { | |
| 29 ChromeRenderViewHostTestHarness::SetUp(); | |
| 30 fake_user_event_service_ = static_cast<syncer::FakeUserEventService*>( | |
| 31 browser_sync::UserEventServiceFactory::GetInstance() | |
| 32 ->SetTestingFactoryAndUse(browser_context(), | |
| 33 &BuildFakeUserEventService)); | |
| 34 } | |
| 35 | |
| 36 void TearDown() override { ChromeRenderViewHostTestHarness::TearDown(); } | |
| 37 | |
| 38 protected: | |
| 39 syncer::FakeUserEventService* GetUserEventService() { | |
| 40 return fake_user_event_service_; | |
| 41 } | |
| 42 | |
| 43 private: | |
| 44 syncer::FakeUserEventService* fake_user_event_service_; | |
| 45 }; | |
| 46 | |
| 47 TEST_F(ChromeTranslateClientTest, LanguageEventShouldRecord) { | |
| 48 GURL url("http://yahoo.com"); | |
| 49 NavigateAndCommit(url); | |
| 50 ChromeTranslateClient client(web_contents()); | |
| 51 translate::LanguageDetectionDetails details; | |
| 52 details.cld_language = "en"; | |
| 53 details.is_cld_reliable = true; | |
| 54 details.adopted_language = "en"; | |
| 55 client.OnLanguageDetermined(details); | |
| 56 EXPECT_EQ(1ul, GetUserEventService()->GetRecordedUserEvents().size()); | |
| 57 } | |
| 58 | |
| 59 TEST_F(ChromeTranslateClientTest, LanguageEventShouldNotRecord) { | |
| 60 GURL url("about://blank"); | |
| 61 NavigateAndCommit(url); | |
| 62 ChromeTranslateClient client(web_contents()); | |
| 63 translate::LanguageDetectionDetails details; | |
| 64 details.cld_language = "en"; | |
| 65 details.is_cld_reliable = true; | |
| 66 details.adopted_language = "en"; | |
| 67 client.OnLanguageDetermined(details); | |
| 68 EXPECT_EQ(0ul, GetUserEventService()->GetRecordedUserEvents().size()); | |
|
skym
2017/06/06 15:46:56
0ul seems a bit odd here, 0u would work just fine,
renjieliu1
2017/06/07 00:23:31
Done.
| |
| 69 } | |
| OLD | NEW |