Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2916863003: Implement library access restrictions and privacy. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Patch Set 3 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -46 lines) Patch
M pkg/front_end/lib/src/fasta/builder/class_builder.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart View 4 chunks +12 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 1 chunk +18 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 4 chunks +13 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 1 3 chunks +6 lines, -5 lines 0 comments Download
M tests/co19/co19-kernel.status View 3 chunks +1 line, -6 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ahe
3 years, 6 months ago (2017-06-01 15:39:22 UTC) #2
Paul Berry
lgtm assuming you follow one of my suggestions below https://codereview.chromium.org/2916863003/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart File pkg/front_end/lib/src/fasta/builder/library_builder.dart (right): https://codereview.chromium.org/2916863003/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart#newcode135 pkg/front_end/lib/src/fasta/builder/library_builder.dart:135: ...
3 years, 6 months ago (2017-06-01 16:54:18 UTC) #3
ahe
Let me know what you think? https://codereview.chromium.org/2916863003/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart File pkg/front_end/lib/src/fasta/builder/library_builder.dart (right): https://codereview.chromium.org/2916863003/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart#newcode135 pkg/front_end/lib/src/fasta/builder/library_builder.dart:135: cls.findConstructorOrFactory(constructorName, -1, null, ...
3 years, 6 months ago (2017-06-01 17:12:43 UTC) #4
Paul Berry
https://codereview.chromium.org/2916863003/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart File pkg/front_end/lib/src/fasta/builder/library_builder.dart (right): https://codereview.chromium.org/2916863003/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart#newcode135 pkg/front_end/lib/src/fasta/builder/library_builder.dart:135: cls.findConstructorOrFactory(constructorName, -1, null, this); On 2017/06/01 17:12:42, ahe wrote: ...
3 years, 6 months ago (2017-06-01 17:15:11 UTC) #5
ahe
Thank you, Paul! https://codereview.chromium.org/2916863003/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart File pkg/front_end/lib/src/fasta/builder/library_builder.dart (right): https://codereview.chromium.org/2916863003/diff/1/pkg/front_end/lib/src/fasta/builder/library_builder.dart#newcode135 pkg/front_end/lib/src/fasta/builder/library_builder.dart:135: cls.findConstructorOrFactory(constructorName, -1, null, this); On 2017/06/01 ...
3 years, 6 months ago (2017-06-02 06:26:51 UTC) #6
ahe
3 years, 6 months ago (2017-06-02 11:13:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
696f00d96b12a72f8792f5156208d523b23e786d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698