Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: src/inspector/injected-script.h

Issue 2916803005: [inspector] Create InjectedScript per session in each context (Closed)
Patch Set: rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/injected-script.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/injected-script.h
diff --git a/src/inspector/injected-script.h b/src/inspector/injected-script.h
index 8854aa1207d2892a6481cbf33050e0cfca69a93d..7b64efcd24fe070b544fd2c27323acaf9825609a 100644
--- a/src/inspector/injected-script.h
+++ b/src/inspector/injected-script.h
@@ -54,7 +54,8 @@ using protocol::Response;
class InjectedScript final {
public:
- static std::unique_ptr<InjectedScript> create(InspectedContext*);
+ static std::unique_ptr<InjectedScript> create(InspectedContext*,
+ int sessionId);
~InjectedScript();
static InjectedScript* fromInjectedScriptHost(v8::Isolate* isolate,
v8::Local<v8::Object>);
@@ -181,7 +182,7 @@ class InjectedScript final {
};
private:
- InjectedScript(InspectedContext*, v8::Local<v8::Object>);
+ InjectedScript(InspectedContext*, v8::Local<v8::Object>, int sessionId);
v8::Local<v8::Value> v8Value() const;
Response wrapValue(v8::Local<v8::Value>, const String16& groupName,
bool forceValueType, bool generatePreview,
@@ -191,6 +192,7 @@ class InjectedScript final {
InspectedContext* m_context;
v8::Global<v8::Value> m_value;
+ int m_sessionId;
v8::Global<v8::Value> m_lastEvaluationResult;
v8::Global<v8::Object> m_commandLineAPI;
int m_lastBoundObjectId = 1;
« no previous file with comments | « no previous file | src/inspector/injected-script.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698