Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2916773002: Fix error recovery for extracting native name. (Closed)

Created:
3 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix error recovery for extracting native name. I discovered this now that native is enabled more widely (see bot failures here: https://build.chromium.org/p/client.dart/builders/vm-kernel-linux-release-x64-be/builds/2731/steps/vm%20tests/logs/stdio) Here is an example input that hit the problem: K() sync* {}; // //# 50: compile-time error TBR=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/2046d08c097d1f12eccdd97320c422f26f38977c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/front_end/lib/src/fasta/parser/dart_vm_native.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-05-31 23:14:07 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 2046d08c097d1f12eccdd97320c422f26f38977c (presubmit successful).
3 years, 6 months ago (2017-05-31 23:17:25 UTC) #4
ahe
3 years, 6 months ago (2017-06-01 13:56:25 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698