Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3096)

Unified Diff: chrome/browser/extensions/bookmark_app_helper.h

Issue 2916753004: Use BookmarkAppConfirmationView on Mac. Delete the NSAlert Mac uses currently. (Closed)
Patch Set: using, OnceCallback Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/bookmark_app_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/bookmark_app_helper.h
diff --git a/chrome/browser/extensions/bookmark_app_helper.h b/chrome/browser/extensions/bookmark_app_helper.h
index 174ede8d9a4891287e26b2ad327c2fde0ba8adc4..414548933e55b42b1a58a4ed5c115bcbdf7a1ec2 100644
--- a/chrome/browser/extensions/bookmark_app_helper.h
+++ b/chrome/browser/extensions/bookmark_app_helper.h
@@ -109,8 +109,8 @@ class BookmarkAppHelper : public content::NotificationObserver {
void CreateFromAppBanner(const CreateBookmarkAppCallback& callback,
const content::Manifest& manifest);
- private:
- friend class TestBookmarkAppHelper;
+ protected:
+ // Protected methods for testing.
// Called by the WebContents when the manifest has been downloaded. If there
// is no manifest, or the WebContents is destroyed before the manifest could
@@ -119,9 +119,11 @@ class BookmarkAppHelper : public content::NotificationObserver {
const content::Manifest& manifest);
// Performs post icon download tasks including installing the bookmark app.
- void OnIconsDownloaded(bool success,
- const std::map<GURL, std::vector<SkBitmap> >& bitmaps);
+ virtual void OnIconsDownloaded(
+ bool success,
+ const std::map<GURL, std::vector<SkBitmap>>& bitmaps);
+ private:
// Called after the bubble has been shown, and the user has either accepted or
// the dialog was dismissed.
void OnBubbleCompleted(bool user_accepted,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/extensions/bookmark_app_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698