Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h

Issue 2916753004: Use BookmarkAppConfirmationView on Mac. Delete the NSAlert Mac uses currently. (Closed)
Patch Set: alrighty Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h
diff --git a/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h b/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h
index d7c6b76abd551174291069e8406ce5692b4648ef..fa6f253d9a11954fbfbef3570ed06074dede9700 100644
--- a/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h
+++ b/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h
@@ -7,7 +7,7 @@
#include "base/macros.h"
#include "base/strings/string16.h"
-#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/common/web_application_info.h"
#include "ui/views/controls/textfield/textfield_controller.h"
#include "ui/views/window/dialog_delegate.h"
@@ -22,18 +22,12 @@ class Textfield;
class BookmarkAppConfirmationView : public views::DialogDelegateView,
public views::TextfieldController {
public:
- ~BookmarkAppConfirmationView() override;
-
- static void CreateAndShow(
- gfx::NativeWindow parent,
- const WebApplicationInfo& web_app_info,
- const BrowserWindow::ShowBookmarkAppBubbleCallback& callback);
-
- private:
BookmarkAppConfirmationView(
const WebApplicationInfo& web_app_info,
- const BrowserWindow::ShowBookmarkAppBubbleCallback& callback);
+ const chrome::ShowBookmarkAppDialogCallback& callback);
+ ~BookmarkAppConfirmationView() override;
+ private:
// Overridden from views::WidgetDelegate:
views::View* GetInitiallyFocusedView() override;
ui::ModalType GetModalType() const override;
@@ -63,7 +57,7 @@ class BookmarkAppConfirmationView : public views::DialogDelegateView,
WebApplicationInfo web_app_info_;
// The callback to be invoked when the dialog is completed.
- BrowserWindow::ShowBookmarkAppBubbleCallback callback_;
+ chrome::ShowBookmarkAppDialogCallback callback_;
// Checkbox to launch as a window.
views::Checkbox* open_as_window_checkbox_;

Powered by Google App Engine
This is Rietveld 408576698