third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js - Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls (Closed)

Patch Set: addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineHistoryManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

index 80095851c8de7638e651bcc4674cf86009698e85..f193a3fa0ec942a9c212f971c5c5e209215363c3 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js

@@ -10,8 +10,10 @@ Sources.ThreadsSidebarPane = class extends UI.VBox {

super(true);

this.registerRequiredCSS('sources/threadsSidebarPane.css');

+ /** @type {!UI.ListModel<!SDK.DebuggerModel>} */

+ this._items = new UI.ListModel();

/** @type {!UI.ListControl<!SDK.DebuggerModel>} */

- this._list = new UI.ListControl(this, UI.ListMode.NonViewport);

+ this._list = new UI.ListControl(this._items, this, UI.ListMode.NonViewport);

this.contentElement.appendChild(this._list.element);

UI.context.addFlavorChangeListener(SDK.Target, this._targetFlavorChanged, this);

@@ -106,7 +108,7 @@ Sources.ThreadsSidebarPane = class extends UI.VBox {

* @param {!SDK.DebuggerModel} debuggerModel

modelAdded(debuggerModel) {

- this._list.pushItem(debuggerModel);

+ this._items.pushItem(debuggerModel);

var currentTarget = UI.context.flavor(SDK.Target);

if (currentTarget === debuggerModel.target())

this._list.selectItem(debuggerModel);

@@ -117,7 +119,7 @@ Sources.ThreadsSidebarPane = class extends UI.VBox {

* @param {!SDK.DebuggerModel} debuggerModel

modelRemoved(debuggerModel) {

- this._list.removeItem(debuggerModel);

+ this._items.removeItem(debuggerModel);

}

/**