third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js - Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls (Closed)

Patch Set: addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

index 86152f7fd21913b9578618009deadef49a819e01..e7deb52c65e67427d3c280b614b22274fb74b0e0 100644

--- a/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

@@ -34,8 +34,10 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {

this._progressElement = this._bottomElementsContainer.createChild('div', 'filtered-list-widget-progress');

this._progressBarElement = this._progressElement.createChild('div', 'filtered-list-widget-progress-bar');

+ /** @type {!UI.ListModel<number>} */

+ this._items = new UI.ListModel();

/** @type {!UI.ListControl<number>} */

- this._list = new UI.ListControl(this, UI.ListMode.EqualHeightItems);

+ this._list = new UI.ListControl(this._items, this, UI.ListMode.EqualHeightItems);

this._itemElementsContainer = this._list.element;

this._itemElementsContainer.classList.add('container');

this._bottomElementsContainer.appendChild(this._itemElementsContainer);

@@ -150,7 +152,7 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {

}

_attachProvider() {

- this._list.replaceAllItems([]);

+ this._items.replaceAllItems([]);

this._list.invalidateItemHeight();

if (this._provider) {

this._provider.setRefreshCallback(this._itemsLoaded.bind(this, this._provider));

@@ -433,7 +435,7 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {

filteredItems = [].concat(bestItems, overflowItems, filteredItems);

this._updateNotFoundMessage(!!filteredItems.length);

var oldHeight = this._list.element.offsetHeight;

- this._list.replaceAllItems(filteredItems);

+ this._items.replaceAllItems(filteredItems);

if (filteredItems.length)

this._list.selectItem(filteredItems[0]);

if (this._list.element.offsetHeight !== oldHeight)