third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js - Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

Issue 2916743002: [DevTools] Introduce Common.List used as a backend for list controls (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

index 03e0c1240095d15a2b3bcd234324ee8a01de71bc..50826e4f31b6e1d6b6caa67f7e96e5ae7820b5e2 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

@@ -316,7 +316,7 @@ UI.SuggestBox = class {

this._updateMaxSize(completions);

this._glassPane.setContentAnchorBox(anchorBox);

this._list.invalidateItemHeight();

- this._list.replaceAllItems(completions);

+ this._list.source().replaceAllItems(completions);

if (selectHighestPriority) {

var highestPriorityItem = completions[0];