[DevTools] Introduce Common.List used as a backend for list controls

third_party/WebKit/Source/devtools/front_end/Tests.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 829 matching lines @@
       this.fail(text);
   };
 
   TestSuite.prototype.testConsoleContextNames = function() {
     var test = this;
     test.takeControl();
     this.showPanel('console').then(() => this._waitForExecutionContexts(2, onExecutionContexts.bind(this)));
 
     function onExecutionContexts() {
       var consoleView = Console.ConsoleView.instance();
-      var items = consoleView._consoleContextSelector._list._items;
+      var items = consoleView._consoleContextSelector._items;
       var values = [];
-      for (var i = 0; i < items.length; ++i)
-        values.push(consoleView._consoleContextSelector._titleFor(items[i]));
+      for (var i = 0; i < items.length(); ++i)

[caseq, 2017/06/01 01:37:56]

Make it iterable?

[dgozman, 2017/06/01 20:31:49]

I'll follow up.

+        values.push(consoleView._consoleContextSelector._titleFor(items.itemAtIndex(i)));
       test.assertEquals('top', values[0]);
       test.assertEquals('Simple content script', values[1]);
       test.releaseControl();
     }
   };
 
   TestSuite.prototype.testDevToolsSharedWorker = function() {
     this.takeControl();
     Bindings.TempFile.ensureTempStorageCleared().then(() => this.releaseControl());
   };
@@ skipping 236 matching lines @@
       if (runtimeModel.executionContexts().length >= n)
         callback.call(null);
       else
         this.addSniffer(SDK.RuntimeModel.prototype, '_executionContextCreated', checkForExecutionContexts.bind(this));
     }
   };
 
 
   window.uiTests = new TestSuite(window.domAutomationController);
 })(window);