Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/timer/timer.h

Issue 2916693002: DetachFromSequence in Timer::Stop() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/timer/timer.cc » ('j') | base/timer/timer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/timer/timer.h
diff --git a/base/timer/timer.h b/base/timer/timer.h
index 88958d4ad65a3abef8976483d758014e097b8b82..7a996e463fb6b6a2b281ba02c30f45818cb929ab 100644
--- a/base/timer/timer.h
+++ b/base/timer/timer.h
@@ -203,7 +203,8 @@ class BASE_EXPORT Timer {
TimeTicks desired_run_time_;
// Timer isn't thread-safe and must only be used on its origin sequence
- // (sequence on which it was started).
+ // (sequence on which it was started). Once fully Stop()'ed it may be
+ // destroyed or even restarted on another sequence.
danakj 2017/06/06 20:07:12 s/even //
gab 2017/06/07 19:02:37 Done.
SequenceChecker origin_sequence_checker_;
// Repeating timers automatically post the task again before calling the task
« no previous file with comments | « no previous file | base/timer/timer.cc » ('j') | base/timer/timer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698