Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: base/task_scheduler/task_tracker_unittest.cc

Issue 2916673003: Disable DCHECK for no BLOCK_SHUTDOWN posted after TaskScheduler shutdown. (Closed)
Patch Set: fix BlockShutdown/TaskSchedulerTaskTrackerTest.WillPostAfterShutdown Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_tracker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_tracker_unittest.cc
diff --git a/base/task_scheduler/task_tracker_unittest.cc b/base/task_scheduler/task_tracker_unittest.cc
index 2fbfff27850efae361719e43d40cd85297f2db40..d7c7b60a97d8d354dc4829224421d1d82bcdd626 100644
--- a/base/task_scheduler/task_tracker_unittest.cc
+++ b/base/task_scheduler/task_tracker_unittest.cc
@@ -412,11 +412,7 @@ TEST_P(TaskSchedulerTaskTrackerTest, WillPostAfterShutdown) {
std::unique_ptr<Task> task(CreateTask(GetParam()));
// |task_tracker_| shouldn't allow a task to be posted after shutdown.
- if (GetParam() == TaskShutdownBehavior::BLOCK_SHUTDOWN) {
robliao 2017/06/01 17:00:53 Instead of deleting this code, should we just disa
gab 2017/06/01 17:59:39 I thought that too but then realized we still need
fdoray 2017/06/02 15:07:47 Acknowledged.
- EXPECT_DCHECK_DEATH({ tracker_.WillPostTask(task.get()); });
- } else {
- EXPECT_FALSE(tracker_.WillPostTask(task.get()));
- }
+ EXPECT_FALSE(tracker_.WillPostTask(task.get()));
}
// Verify that BLOCK_SHUTDOWN and SKIP_ON_SHUTDOWN tasks can
« no previous file with comments | « base/task_scheduler/task_tracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698