Set return type of factory constructors properly.

Set return type of factory constructors properly.

And remove workarounds from type inference logic.

[Paul Berry, 2017-05-31 17:51:31]

paulberry@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-06-01 09:10:09]

Thank you, Paul. It looks like the final CL will be an amalgamation of our two
CLs, this and 2917853002.

I think you can close this now, but this was very helpful!

https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (left):

https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:487: }
I have to "steal" this :-)

https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart (right):

https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart:128: if (kind
== ProcedureKind.Factory) {
This I have a different solution for.

https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):

https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:40: return
constructor.function.returnType;
I also have to "steal" all these changes :-)

[Paul Berry, 2017-06-01 13:03:47]

On 2017/06/01 09:10:09, ahe wrote:
> Thank you, Paul. It looks like the final CL will be an amalgamation of our two
> CLs, this and 2917853002.
> 
> I think you can close this now, but this was very helpful!
> 
>
https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
> File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (left):
> 
>
https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/kernel/body_builder.dart:487: }
> I have to "steal" this :-)
> 
>
https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
> File pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart (right):
> 
>
https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart:128: if (kind
> == ProcedureKind.Factory) {
> This I have a different solution for.
> 
>
https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
> File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right):
> 
>
https://codereview.chromium.org/2916533003/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:40: return
> constructor.function.returnType;
> I also have to "steal" all these changes :-)

Thanks for "stealing" my changes--it saved me a bunch of effort :)

I looked over your CL and I agree that we don't need this one anymore. 
Closing...