Issue 291653007: Cleanup, mostly replacing uses of SplitStringUsingSubstr() with SplitString(),

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291653007: Cleanup, mostly replacing uses of SplitStringUsingSubstr() with SplitString(), (Closed)

Created:
6 years, 7 months ago by Peter Kasting

Modified:
6 years, 7 months ago

Reviewers:
eroman, sky

CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, grt+watch_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup, mostly replacing uses of SplitStringUsingSubstr() with SplitString(), also some other misc. changes to shorten code, remove a using directive, etc. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272624

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -86 lines)			Patch
M	chrome/browser/prerender/prerender_field_trial.cc	View	7 chunks	+20 lines, -39 lines	0 comments	Download
M	chrome/common/variations/experiment_labels.cc	View	5 chunks	+7 lines, -13 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi_omaha_experiment.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/installer/gcapi/gcapi_omaha_experiment_test.cc	View	7 chunks	+23 lines, -23 lines	0 comments	Download
M	chrome/installer/util/google_update_experiment_util.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/installer/util/google_update_experiment_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/mime_util.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/291653007/1

6 years, 7 months ago (2014-05-23 20:24:33 UTC) #5

Message was sent while issue was closed.

Change committed as 272624

Expand Messages | Collapse Messages