Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 291653003: Add a unit test for the experimental app list. (Closed)

Created:
6 years, 7 months ago by calamity
Modified:
6 years, 7 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Add a unit test for the experimental app list. This CL adds a unit test for the experimental app list that instantiates the app list in experimental mode and performs a series of very basic checks. BUG=349727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272871

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments, make new test actually run..... #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -19 lines) Patch
M ui/app_list/views/app_list_view_unittest.cc View 1 11 chunks +87 lines, -13 lines 0 comments Download
M ui/app_list/views/contents_view.h View 1 4 chunks +5 lines, -1 line 0 comments Download
M ui/app_list/views/contents_view.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M ui/app_list/views/start_page_view.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
calamity
6 years, 7 months ago (2014-05-22 03:29:26 UTC) #1
tapted
https://codereview.chromium.org/291653003/diff/1/ui/app_list/views/app_list_view_unittest.cc File ui/app_list/views/app_list_view_unittest.cc (right): https://codereview.chromium.org/291653003/diff/1/ui/app_list/views/app_list_view_unittest.cc#newcode245 ui/app_list/views/app_list_view_unittest.cc:245: if (test_type_ != EXPERIMENTAL) Can it still PopulateApps, and ...
6 years, 7 months ago (2014-05-22 05:01:27 UTC) #2
calamity
https://codereview.chromium.org/291653003/diff/1/ui/app_list/views/app_list_view_unittest.cc File ui/app_list/views/app_list_view_unittest.cc (right): https://codereview.chromium.org/291653003/diff/1/ui/app_list/views/app_list_view_unittest.cc#newcode245 ui/app_list/views/app_list_view_unittest.cc:245: if (test_type_ != EXPERIMENTAL) On 2014/05/22 05:01:27, tapted wrote: ...
6 years, 7 months ago (2014-05-23 04:10:23 UTC) #3
tapted
niice - lgtm
6 years, 7 months ago (2014-05-23 06:32:51 UTC) #4
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 7 months ago (2014-05-26 04:42:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/291653003/30001
6 years, 7 months ago (2014-05-26 04:42:59 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 20:06:34 UTC) #7
Message was sent while issue was closed.
Change committed as 272871

Powered by Google App Engine
This is Rietveld 408576698