Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web/web_state/web_state_impl.mm

Issue 2916473002: [ObjC ARC] Converts ios/web:web to ARC. (Closed)
Patch Set: Tweaks to unit test memory management Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/web/web_state/ui/crw_wk_script_message_router.mm ('K') | « ios/web/web_state/web_state_delegate_bridge.mm ('k') | ios/web/web_state/web_state_observer.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/web_state_impl.mm
diff --git a/ios/web/web_state/web_state_impl.mm b/ios/web/web_state/web_state_impl.mm
index de5e4b97b79629f782af4f2a69367a7974b32070..7808f7502e6668ff4ab93ee8c2cc04b3616e1f86 100644
--- a/ios/web/web_state/web_state_impl.mm
+++ b/ios/web/web_state/web_state_impl.mm
@@ -38,6 +38,10 @@
#include "ios/web/webui/web_ui_ios_impl.h"
#include "net/http/http_response_headers.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace web {
/* static */
@@ -162,7 +166,7 @@ CRWWebController* WebStateImpl::GetWebController() {
void WebStateImpl::SetWebController(CRWWebController* web_controller) {
[web_controller_ close];
- web_controller_.reset([web_controller retain]);
+ web_controller_.reset(web_controller);
PL 2017/06/01 01:56:21 The converter created this, but can we just assign
}
void WebStateImpl::OnTitleChanged() {
« ios/web/web_state/ui/crw_wk_script_message_router.mm ('K') | « ios/web/web_state/web_state_delegate_bridge.mm ('k') | ios/web/web_state/web_state_observer.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698