[ObjC ARC] Converts ios/web:web to ARC.

ios/web/web_state/wk_web_view_security_util.mm

Index: ios/web/web_state/wk_web_view_security_util.mm
diff --git a/ios/web/web_state/wk_web_view_security_util.mm b/ios/web/web_state/wk_web_view_security_util.mm
index 5b7e446655eda9646d004b66b429f06330a91e8b..c4d10574ae478ce1405be2b43bbb27bf19106f1e 100644
--- a/ios/web/web_state/wk_web_view_security_util.mm
+++ b/ios/web/web_state/wk_web_view_security_util.mm
@@ -10,6 +10,10 @@
 #include "net/cert/x509_util_ios.h"
 #include "net/ssl/ssl_info.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace web {
 
 // These keys were determined by inspecting userInfo dict of an SSL error.
@@ -50,10 +54,12 @@ scoped_refptr<net::X509Certificate> CreateCertFromChain(NSArray* certs) {
     return nullptr;
   std::vector<SecCertificateRef> intermediates;
   for (NSUInteger i = 1; i < certs.count; i++) {
-    intermediates.push_back(reinterpret_cast<SecCertificateRef>(certs[i]));
+    SecCertificateRef cert = (__bridge SecCertificateRef)certs[i];

[stkhapugin, 2017/06/12 12:36:23]

nit: I think this will be better if you use a local for certs[i] to improve
readability.

[PL, 2017/06/14 00:31:11]

Thanks! I think I need a bit more guidance here, I'm not sure how to break this
down further as |cert| is a local variable for certs[i]. What am I missing :-) ?

[stkhapugin, 2017/06/14 17:00:59]

Oh, sorry, my comment is indeed confusing. I meant - create a local variable
that's not an array, then cast it separately, so something like:

id tmp_cert = certs[i];
SecCertificateRef cert = (__bridge SecCertiifcateRef)tmp_cert;

But looking at this, this is even uglier, so disregard this!

+    intermediates.push_back(cert);
   }
+  SecCertificateRef root_cert = (__bridge SecCertificateRef)certs[0];
   return net::x509_util::CreateX509CertificateFromSecCertificate(
-      reinterpret_cast<SecCertificateRef>(certs[0]), intermediates);
+      reinterpret_cast<SecCertificateRef>(root_cert), intermediates);
 }
 
 scoped_refptr<net::X509Certificate> CreateCertFromTrust(SecTrustRef trust) {
@@ -83,8 +89,8 @@ base::ScopedCFTypeRef<SecTrustRef> CreateServerTrustFromChain(NSArray* certs,
   base::ScopedCFTypeRef<SecPolicyRef> policy(
       SecPolicyCreateSSL(TRUE, static_cast<CFStringRef>(host)));
   SecTrustRef ref_result = nullptr;
-  if (SecTrustCreateWithCertificates(certs, policy, &ref_result) ==
-      errSecSuccess) {
+  if (SecTrustCreateWithCertificates((__bridge CFArrayRef)certs, policy,
+                                     &ref_result) == errSecSuccess) {
     scoped_result.reset(ref_result);
   }
   return scoped_result;