[ObjC ARC] Converts ios/web:web to ARC.

ios/web/web_state/ui/crw_web_controller_container_view.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/ui/crw_web_controller_container_view.h"
 
-#import "base/ios/weak_nsobject.h"
 #include "base/logging.h"
-#import "base/mac/scoped_nsobject.h"
 #import "ios/web/public/web_state/ui/crw_content_view.h"
 #import "ios/web/public/web_state/ui/crw_native_content.h"
 #import "ios/web/public/web_state/ui/crw_web_view_content_view.h"
 #import "ios/web/web_state/ui/crw_web_view_proxy_impl.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 #pragma mark - CRWToolbarContainerView
 
 // Class that manages the display of toolbars.
 @interface CRWToolbarContainerView : UIView {
   // Backing object for |self.toolbars|.
-  base::scoped_nsobject<NSMutableArray> _toolbars;
+  NSMutableArray* _toolbars;
 }
 
 // The toolbars currently managed by this view.
-@property(nonatomic, retain, readonly) NSMutableArray* toolbars;
+@property(nonatomic, strong, readonly) NSMutableArray* toolbars;
 
 // Adds |toolbar| as a subview and bottom aligns to any previously added
 // toolbars.
 - (void)addToolbar:(UIView*)toolbar;
 
 // Removes |toolbar| from the container view.
 - (void)removeToolbar:(UIView*)toolbar;
 
 @end
 
 @implementation CRWToolbarContainerView
 
 #pragma mark Accessors
 
 - (NSMutableArray*)toolbars {
   if (!_toolbars)
-    _toolbars.reset([[NSMutableArray alloc] init]);
-  return _toolbars.get();
+    _toolbars = [[NSMutableArray alloc] init];
+  return _toolbars;
 }
 
 #pragma mark Layout
 
 - (void)layoutSubviews {
   [super layoutSubviews];
 
   // Bottom-align the toolbars.
   CGPoint toolbarOrigin =
       CGPointMake(self.bounds.origin.x, CGRectGetMaxY(self.bounds));
@@ skipping 30 matching lines @@
   [self.toolbars removeObject:toolbar];
   [toolbar removeFromSuperview];
 }
 
 @end
 
 #pragma mark - CRWWebControllerContainerView
 
 @interface CRWWebControllerContainerView () {
   // The delegate passed on initialization.
-  base::WeakNSProtocol<id<CRWWebControllerContainerViewDelegate>> _delegate;
+  __weak id<CRWWebControllerContainerViewDelegate> _delegate;
   // Backing objects for corresponding properties.
-  base::scoped_nsobject<CRWWebViewContentView> _webViewContentView;
-  base::scoped_nsprotocol<id<CRWNativeContent>> _nativeController;
-  base::scoped_nsobject<CRWContentView> _transientContentView;
-  base::scoped_nsobject<CRWToolbarContainerView> _toolbarContainerView;
+  CRWWebViewContentView* _webViewContentView;
+  id<CRWNativeContent> _nativeController;
+  CRWContentView* _transientContentView;
+  CRWToolbarContainerView* _toolbarContainerView;
 }
 
 // Redefine properties as readwrite.
-@property(nonatomic, retain, readwrite)
+@property(nonatomic, strong, readwrite)
     CRWWebViewContentView* webViewContentView;
-@property(nonatomic, retain, readwrite) id<CRWNativeContent> nativeController;
-@property(nonatomic, retain, readwrite) CRWContentView* transientContentView;
+@property(nonatomic, strong, readwrite) id<CRWNativeContent> nativeController;
+@property(nonatomic, strong, readwrite) CRWContentView* transientContentView;
 
 // Container view that displays any added toolbars.  It is always the top-most
 // subview, and is bottom aligned with the CRWWebControllerContainerView.
-@property(nonatomic, retain, readonly)
+@property(nonatomic, strong, readonly)
     CRWToolbarContainerView* toolbarContainerView;
 
 // Convenience getter for the proxy object.
-@property(nonatomic, readonly) CRWWebViewProxyImpl* contentViewProxy;
+@property(weak, nonatomic, readonly) CRWWebViewProxyImpl* contentViewProxy;
 
 // Returns |self.bounds| after being inset at the top by the header height
 // returned by the delegate.  This is only used to lay out native controllers,
 // as the header height is already accounted for in the scroll view content
 // insets for other CRWContentViews.
 @property(nonatomic, readonly) CGRect visibleFrame;
 
 @end
 
 @implementation CRWWebControllerContainerView
 
 - (instancetype)initWithDelegate:
         (id<CRWWebControllerContainerViewDelegate>)delegate {
   self = [super initWithFrame:CGRectZero];
   if (self) {
     DCHECK(delegate);
-    _delegate.reset(delegate);
+    _delegate = delegate;
     self.backgroundColor = [UIColor whiteColor];
     self.autoresizingMask =
         UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
   }
   return self;
 }
 
 - (instancetype)initWithCoder:(NSCoder*)decoder {
   NOTREACHED();
   return nil;
 }
 
 - (instancetype)initWithFrame:(CGRect)frame {
   NOTREACHED();
   return nil;
 }
 
 - (void)dealloc {
   self.contentViewProxy.contentView = nil;
-  [super dealloc];
 }
 
 #pragma mark Accessors
 
 - (CRWWebViewContentView*)webViewContentView {

[Eugene But (OOO till 7-30), 2017/06/12 06:12:51]

Should we synthesize this method instead?

[PL, 2017/06/14 00:31:11]

Yes! Done!

-  return _webViewContentView.get();
+  return _webViewContentView;
 }
 
 - (void)setWebViewContentView:(CRWWebViewContentView*)webViewContentView {
   if (![_webViewContentView isEqual:webViewContentView]) {
     [_webViewContentView removeFromSuperview];
-    _webViewContentView.reset([webViewContentView retain]);
+    _webViewContentView = webViewContentView;
     [_webViewContentView setFrame:self.bounds];
     [self addSubview:_webViewContentView];
   }
 }
 
 - (id<CRWNativeContent>)nativeController {

[Eugene But (OOO till 7-30), 2017/06/12 06:12:51]

ditto

[PL, 2017/06/14 00:31:11]

Done!

-  return _nativeController.get();
+  return _nativeController;
 }
 
 - (void)setNativeController:(id<CRWNativeContent>)nativeController {
   if (![_nativeController isEqual:nativeController]) {
-    base::WeakNSProtocol<id> oldController(_nativeController);
+    __weak id oldController = _nativeController;
     if ([oldController respondsToSelector:@selector(willBeDismissed)]) {
       [oldController willBeDismissed];
     }
     [[oldController view] removeFromSuperview];
-    _nativeController.reset([nativeController retain]);
+    _nativeController = nativeController;
     // TODO(crbug.com/503297): Re-enable this DCHECK once native controller
     // leaks are fixed.
     //    DCHECK(!oldController);
   }
 }
 
 - (CRWContentView*)transientContentView {

[Eugene But (OOO till 7-30), 2017/06/12 06:12:51]

ditto

[PL, 2017/06/14 00:31:11]

Done!

-  return _transientContentView.get();
+  return _transientContentView;
 }
 
 - (void)setTransientContentView:(CRWContentView*)transientContentView {
   if (![_transientContentView isEqual:transientContentView]) {
     [_transientContentView removeFromSuperview];
-    _transientContentView.reset([transientContentView retain]);
+    _transientContentView = transientContentView;
   }
 }
 
 - (void)setToolbarContainerView:(CRWToolbarContainerView*)toolbarContainerView {
   if (![_toolbarContainerView isEqual:toolbarContainerView]) {
     [_toolbarContainerView removeFromSuperview];
-    _toolbarContainerView.reset([toolbarContainerView retain]);
+    _toolbarContainerView = toolbarContainerView;
   }
 }
 
 - (UIView*)toolbarContainerView {

[Eugene But (OOO till 7-30), 2017/06/12 06:12:51]

ditto

[PL, 2017/06/14 00:31:11]

Done!

-  return _toolbarContainerView.get();
+  return _toolbarContainerView;
 }
 
 - (CRWWebViewProxyImpl*)contentViewProxy {
   return [_delegate contentViewProxyForContainerView:self];
 }
 
 - (CGRect)visibleFrame {
   CGFloat headerHeight = [_delegate headerHeightForContainerView:self];
   return UIEdgeInsetsInsetRect(self.bounds,
                                UIEdgeInsetsMake(headerHeight, 0, 0, 0));
 }
 
 - (id<CRWWebControllerContainerViewDelegate>)delegate {

[Eugene But (OOO till 7-30), 2017/06/12 06:12:52]

Should we synthesize getter and setter instead? Same question for
toolbarContainerView

[PL, 2017/06/14 00:31:11]

Done! We can do it easily for delegate, toolbarContainerView will still need to
keep its overridden method as it's more than just a simple set of an object.

-  return _delegate.get();
+  return _delegate;
 }
 
 - (void)setDelegate:(id<CRWWebControllerContainerViewDelegate>)delegate {
-  _delegate.reset(delegate);
+  _delegate = delegate;
 }
 
 #pragma mark Layout
 
 - (void)layoutSubviews {
   [super layoutSubviews];
 
   self.webViewContentView.frame = self.bounds;
 
   // TODO(crbug.com/570114): Move adding of the following subviews to another
@@ skipping 74 matching lines @@
 - (void)clearTransientContentView {
   self.transientContentView = nil;
   self.contentViewProxy.contentView = self.webViewContentView;
 }
 
 #pragma mark Toolbars
 
 - (void)addToolbar:(UIView*)toolbar {
   // Create toolbar container if necessary.
   if (!self.toolbarContainerView) {
-    self.toolbarContainerView = [
-        [[CRWToolbarContainerView alloc] initWithFrame:CGRectZero] autorelease];
+    self.toolbarContainerView =
+        [[CRWToolbarContainerView alloc] initWithFrame:CGRectZero];
   }
   // Add the toolbar to the container.
   [self.toolbarContainerView addToolbar:toolbar];
   [self setNeedsLayout];
 }
 
 - (void)addToolbars:(NSArray*)toolbars {
   DCHECK(toolbars);
   for (UIView* toolbar in toolbars)
     [self addToolbar:toolbar];
 }
 
 - (void)removeToolbar:(UIView*)toolbar {
   // Remove the toolbar from the container view.
   [self.toolbarContainerView removeToolbar:toolbar];
   // Reset the container if there are no more toolbars.
   if ([self.toolbarContainerView.toolbars count])
     [self setNeedsLayout];
   else
     self.toolbarContainerView = nil;
 }
 
 - (void)removeAllToolbars {
   // Resetting the property will remove the toolbars from the hierarchy.
   self.toolbarContainerView = nil;
 }
 
 @end