[ObjC ARC] Converts ios/web:web to ARC.

ios/web/web_state/wk_web_view_security_util.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/wk_web_view_security_util.h"
 
 #include "base/mac/scoped_cftyperef.h"
 #include "base/strings/sys_string_conversions.h"
 #include "net/cert/x509_certificate.h"
 #include "net/cert/x509_util_ios.h"
 #include "net/ssl/ssl_info.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace web {
 
 // These keys were determined by inspecting userInfo dict of an SSL error.
 NSString* const kNSErrorPeerCertificateChainKey =
     @"NSErrorPeerCertificateChainKey";
 NSString* const kNSErrorFailingURLKey = @"NSErrorFailingURLKey";
 }
 
 namespace {
 
@@ skipping 20 matching lines @@
 }  // namespace
 
 
 namespace web {
 
 scoped_refptr<net::X509Certificate> CreateCertFromChain(NSArray* certs) {
   if (certs.count == 0)
     return nullptr;
   std::vector<SecCertificateRef> intermediates;
   for (NSUInteger i = 1; i < certs.count; i++) {
-    intermediates.push_back(reinterpret_cast<SecCertificateRef>(certs[i]));
+    SecCertificateRef cert = (__bridge SecCertificateRef)certs[i];
+    intermediates.push_back(cert);
   }
+  SecCertificateRef initialCert = (__bridge SecCertificateRef)certs[0];

[Eugene But (OOO till 7-30), 2017/06/02 23:18:38]

s/initialCert/root_cert

[PL, 2017/06/05 23:26:18]

Done!

   return net::x509_util::CreateX509CertificateFromSecCertificate(
-      reinterpret_cast<SecCertificateRef>(certs[0]), intermediates);
+      reinterpret_cast<SecCertificateRef>(initialCert), intermediates);
 }
 
 scoped_refptr<net::X509Certificate> CreateCertFromTrust(SecTrustRef trust) {
   if (!trust)
     return nullptr;
 
   CFIndex cert_count = SecTrustGetCertificateCount(trust);
   if (cert_count == 0) {
     // At the moment there is no API which allows trust creation w/o certs.
     return nullptr;
   }
 
   std::vector<SecCertificateRef> intermediates;
   for (CFIndex i = 1; i < cert_count; i++) {
     intermediates.push_back(SecTrustGetCertificateAtIndex(trust, i));
   }
   return net::x509_util::CreateX509CertificateFromSecCertificate(
       SecTrustGetCertificateAtIndex(trust, 0), intermediates);
 }
 
 base::ScopedCFTypeRef<SecTrustRef> CreateServerTrustFromChain(NSArray* certs,
                                                               NSString* host) {
   base::ScopedCFTypeRef<SecTrustRef> scoped_result;
   if (certs.count == 0)
     return scoped_result;
 
   base::ScopedCFTypeRef<SecPolicyRef> policy(
       SecPolicyCreateSSL(TRUE, static_cast<CFStringRef>(host)));
   SecTrustRef ref_result = nullptr;
-  if (SecTrustCreateWithCertificates(certs, policy, &ref_result) ==
+  CFArrayRef certificatesArray = (__bridge CFArrayRef)certs;

[Eugene But (OOO till 7-30), 2017/06/02 23:18:38]

Do you want to drop this local variable? It's hard to name it. But if you choose
to keep it then s/certificatesArray/certificates_array

[PL, 2017/06/05 23:26:18]

Done! Thanks!

+  if (SecTrustCreateWithCertificates(certificatesArray, policy, &ref_result) ==
       errSecSuccess) {
     scoped_result.reset(ref_result);
   }
   return scoped_result;
 }
 
 void EnsureFutureTrustEvaluationSucceeds(SecTrustRef trust) {
   base::ScopedCFTypeRef<CFDataRef> exceptions(SecTrustCopyExceptions(trust));
   SecTrustSetExceptions(trust, exceptions);
 }
@@ skipping 48 matching lines @@
     // kSecTrustResultConfirm was deprecated in iOS7, but leads to a compile
     // error if used with newer SDKs.  Remove the default clause once this
     // switch statement successfully compiles without kSecTrustResultConfirm.
     default:
       NOTREACHED();
       return SECURITY_STYLE_UNKNOWN;
   }
 }
 
 }  // namespace web