third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h - Issue 2916463002: Refactor DocumentMarkerController::Add*Marker() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2916463002: Refactor DocumentMarkerController::Add*Marker() methods (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

index 746aeb784f08576412d7ca3ef9c0c80cb269d00d..347fc664a1922a6f57ba03c721dfe469180dd170 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

@@ -111,7 +111,10 @@ class CORE_EXPORT DocumentMarkerController final

unsigned new_length) final;

private:

- void AddMarker(Node*, DocumentMarker*);

+ void AddMarkerInternal(

+ const EphemeralRange&,

+ std::function<DocumentMarker*(int, int)> create_marker_from_offsets);

+ void AddMarkerToNode(Node*, DocumentMarker*);

void AddSpellCheckMarker(const Position& start,

const Position& end,

DocumentMarker::MarkerType,