Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2916453003: Fix VM to accept literal function type as type bound (fixes #29481). (Closed)

Created:
3 years, 6 months ago by regis
Modified:
3 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix VM to accept literal function type as type bound (fixes #29481). Add regression test. Mark status files for failing dart2js and analyzer (filed new issues). R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f0faae52bffa47fcf10476b340acadf55fadf87d

Patch Set 1 #

Patch Set 2 : void alone as bound is not accepted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M runtime/vm/parser.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/regress_29481_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 6 months ago (2017-05-30 22:51:44 UTC) #2
siva
lgtm
3 years, 6 months ago (2017-05-31 00:22:40 UTC) #3
regis
3 years, 6 months ago (2017-05-31 00:26:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f0faae52bffa47fcf10476b340acadf55fadf87d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698