Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: components/bookmarks/core/browser/bookmark_client.h

Issue 291643002: Move favicon callbacks to favicon_base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android unittest Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/core/browser/bookmark_client.h
diff --git a/components/bookmarks/core/browser/bookmark_client.h b/components/bookmarks/core/browser/bookmark_client.h
index 35ac50976649ad86965cc499e2432ca1cfc5ddbf..202d16084dea8b9453852bbac8e18717f7d89e23 100644
--- a/components/bookmarks/core/browser/bookmark_client.h
+++ b/components/bookmarks/core/browser/bookmark_client.h
@@ -11,6 +11,7 @@
#include "base/callback_forward.h"
#include "base/task/cancelable_task_tracker.h"
+#include "components/favicon_base/favicon_callback.h"
class BookmarkNode;
class GURL;
@@ -19,18 +20,10 @@ namespace base {
struct UserMetricsAction;
}
-namespace favicon_base {
-struct FaviconImageResult;
-}
-
// This class abstracts operations that depends on the embedder's environment,
// e.g. Chrome.
class BookmarkClient {
public:
- // Callback for GetFaviconImageForURL().
- typedef base::Callback<void(const favicon_base::FaviconImageResult&)>
- FaviconImageCallback;
-
// Types representing a set of BookmarkNode and a mapping from BookmarkNode
// to the number of time the corresponding URL has been typed by the user in
// the Omnibox.
@@ -50,7 +43,7 @@ class BookmarkClient {
const GURL& page_url,
int icon_types,
int desired_size_in_dip,
- const FaviconImageCallback& callback,
+ const favicon_base::FaviconImageCallback& callback,
base::CancelableTaskTracker* tracker);
// Returns true if the embedder supports typed count for URL.

Powered by Google App Engine
This is Rietveld 408576698