Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: chrome/browser/history/history_service.cc

Issue 291643002: Move favicon callbacks to favicon_base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android unittest Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_service.cc
diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc
index 6bf46eebda91646f46ed734a497562d9128ade44..2746ab5ab1111b2fc7df5d303778cf2dbfa36b00 100644
--- a/chrome/browser/history/history_service.cc
+++ b/chrome/browser/history/history_service.cc
@@ -74,12 +74,12 @@ namespace {
static const char* kHistoryThreadName = "Chrome_HistoryThread";
void RunWithFaviconResults(
- const FaviconService::FaviconResultsCallback& callback,
+ const favicon_base::FaviconResultsCallback& callback,
std::vector<favicon_base::FaviconBitmapResult>* bitmap_results) {
callback.Run(*bitmap_results);
}
-void RunWithFaviconResult(const FaviconService::FaviconRawCallback& callback,
+void RunWithFaviconResult(const favicon_base::FaviconRawCallback& callback,
favicon_base::FaviconBitmapResult* bitmap_result) {
callback.Run(*bitmap_result);
}
@@ -559,7 +559,7 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFavicons(
int icon_types,
int desired_size_in_dip,
const std::vector<ui::ScaleFactor>& desired_scale_factors,
- const FaviconService::FaviconResultsCallback& callback,
+ const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -583,7 +583,7 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFaviconsForURL(
int icon_types,
int desired_size_in_dip,
const std::vector<ui::ScaleFactor>& desired_scale_factors,
- const FaviconService::FaviconResultsCallback& callback,
+ const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -606,7 +606,7 @@ base::CancelableTaskTracker::TaskId HistoryService::GetLargestFaviconForURL(
const GURL& page_url,
const std::vector<int>& icon_types,
int minimum_size_in_pixels,
- const FaviconService::FaviconRawCallback& callback,
+ const favicon_base::FaviconRawCallback& callback,
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -628,7 +628,7 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFaviconForID(
favicon_base::FaviconID favicon_id,
int desired_size_in_dip,
ui::ScaleFactor desired_scale_factor,
- const FaviconService::FaviconResultsCallback& callback,
+ const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -653,7 +653,7 @@ HistoryService::UpdateFaviconMappingsAndFetch(
int icon_types,
int desired_size_in_dip,
const std::vector<ui::ScaleFactor>& desired_scale_factors,
- const FaviconService::FaviconResultsCallback& callback,
+ const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker) {
DCHECK(thread_checker_.CalledOnValidThread());

Powered by Google App Engine
This is Rietveld 408576698