Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 291643002: Move favicon callbacks to favicon_base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android unittest Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_handler_unittest.cc
diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc
index a080949b73d27d23903b0f1eeac6a0d82ef3bcc8..7c0629b570ee0d8b134f2cfa7283dd812f3f063a 100644
--- a/chrome/browser/favicon/favicon_handler_unittest.cc
+++ b/chrome/browser/favicon/favicon_handler_unittest.cc
@@ -4,6 +4,7 @@
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/favicon/favicon_handler.h"
+#include "chrome/browser/favicon/favicon_service.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/profiles/profile.h"
@@ -135,7 +136,7 @@ class HistoryRequestHandler {
HistoryRequestHandler(const GURL& page_url,
const GURL& icon_url,
int icon_type,
- const FaviconService::FaviconResultsCallback& callback)
+ const favicon_base::FaviconResultsCallback& callback)
: page_url_(page_url),
icon_url_(icon_url),
icon_type_(icon_type),
@@ -163,7 +164,7 @@ class HistoryRequestHandler {
const std::vector<unsigned char> bitmap_data_;
const gfx::Size size_;
std::vector<favicon_base::FaviconBitmapResult> history_results_;
- FaviconService::FaviconResultsCallback callback_;
+ favicon_base::FaviconResultsCallback callback_;
private:
DISALLOW_COPY_AND_ASSIGN(HistoryRequestHandler);
@@ -293,7 +294,7 @@ class TestFaviconHandler : public FaviconHandler {
const GURL& page_url,
const GURL& icon_url,
favicon_base::IconType icon_type,
- const FaviconService::FaviconResultsCallback& callback,
+ const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker) OVERRIDE {
history_handler_.reset(new HistoryRequestHandler(page_url, icon_url,
icon_type, callback));
@@ -302,7 +303,7 @@ class TestFaviconHandler : public FaviconHandler {
virtual void GetFaviconFromFaviconService(
const GURL& icon_url,
favicon_base::IconType icon_type,
- const FaviconService::FaviconResultsCallback& callback,
+ const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker) OVERRIDE {
history_handler_.reset(new HistoryRequestHandler(GURL(), icon_url,
icon_type, callback));
@@ -311,7 +312,7 @@ class TestFaviconHandler : public FaviconHandler {
virtual void GetFaviconForURLFromFaviconService(
const GURL& page_url,
int icon_types,
- const FaviconService::FaviconResultsCallback& callback,
+ const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker) OVERRIDE {
history_handler_.reset(new HistoryRequestHandler(page_url, GURL(),
icon_types, callback));
@@ -1002,7 +1003,7 @@ TEST_F(FaviconHandlerTest, UpdateDuringDownloading) {
// Reset the history_handler to verify whether favicon is request from
// history.
// Save the callback for late use.
- FaviconService::FaviconResultsCallback callback = history_handler->callback_;
+ favicon_base::FaviconResultsCallback callback = history_handler->callback_;
helper.set_history_handler(NULL);
// Simulates download succeed.

Powered by Google App Engine
This is Rietveld 408576698