components/bookmarks/core/browser/bookmark_client.cc - Issue 291643002: Move favicon callbacks to favicon_base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/core/browser/bookmark_client.cc

Issue 291643002: Move favicon callbacks to favicon_base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/core/browser/bookmark_client.cc

diff --git a/components/bookmarks/core/browser/bookmark_client.cc b/components/bookmarks/core/browser/bookmark_client.cc

index 4b600e39413a0ffca4a8cbbc8887aa5d4fe16ec0..240705f9bb43aa8d6a7b8f7a9756e411abf09dd9 100644

--- a/components/bookmarks/core/browser/bookmark_client.cc

+++ b/components/bookmarks/core/browser/bookmark_client.cc

@@ -14,7 +14,7 @@ base::CancelableTaskTracker::TaskId BookmarkClient::GetFaviconImageForURL(

const GURL& page_url,

int icon_types,

int desired_size_in_dip,

- const FaviconImageCallback& callback,

+ const favicon_base::FaviconImageCallback& callback,

base::CancelableTaskTracker* tracker) {

return base::CancelableTaskTracker::kBadTaskId;

}