chrome/browser/android/favicon_helper.cc - Issue 291643002: Move favicon callbacks to favicon_base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/favicon_helper.cc

Issue 291643002: Move favicon callbacks to favicon_base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/favicon_helper.cc

diff --git a/chrome/browser/android/favicon_helper.cc b/chrome/browser/android/favicon_helper.cc

index 07840d8704450a18038e5f5c06db54844b171f35..d2227b33f3d32c51bc7046d244b58f824eac3939 100644

--- a/chrome/browser/android/favicon_helper.cc

+++ b/chrome/browser/android/favicon_helper.cc

@@ -125,7 +125,7 @@ jboolean FaviconHelper::GetLocalFaviconImageForURL(

new ScopedJavaGlobalRef<jobject>();

j_scoped_favicon_callback->Reset(env, j_favicon_image_callback);

- FaviconService::FaviconImageCallback callback_runner = base::Bind(

+ favicon_base::FaviconImageCallback callback_runner = base::Bind(

&OnLocalFaviconAvailable, base::Owned(j_scoped_favicon_callback));

favicon_service->GetFaviconImageForURL(