Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.h

Issue 291643002: Move favicon callbacks to favicon_base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android unittest Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_
6 #define CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_ 6 #define CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "components/favicon_base/favicon_callback.h"
10 #include "content/public/browser/web_ui.h" 11 #include "content/public/browser/web_ui.h"
11 #include "content/public/browser/web_ui_controller_factory.h" 12 #include "content/public/browser/web_ui_controller_factory.h"
12 #include "chrome/browser/favicon/favicon_service.h"
13 13
14 class Profile; 14 class Profile;
15 15
16 namespace base { 16 namespace base {
17 class RefCountedMemory; 17 class RefCountedMemory;
18 } 18 }
19 19
20 class ChromeWebUIControllerFactory : public content::WebUIControllerFactory { 20 class ChromeWebUIControllerFactory : public content::WebUIControllerFactory {
21 public: 21 public:
22 virtual content::WebUI::TypeID GetWebUIType( 22 virtual content::WebUI::TypeID GetWebUIType(
23 content::BrowserContext* browser_context, 23 content::BrowserContext* browser_context,
24 const GURL& url) const OVERRIDE; 24 const GURL& url) const OVERRIDE;
25 virtual bool UseWebUIForURL(content::BrowserContext* browser_context, 25 virtual bool UseWebUIForURL(content::BrowserContext* browser_context,
26 const GURL& url) const OVERRIDE; 26 const GURL& url) const OVERRIDE;
27 virtual bool UseWebUIBindingsForURL(content::BrowserContext* browser_context, 27 virtual bool UseWebUIBindingsForURL(content::BrowserContext* browser_context,
28 const GURL& url) const OVERRIDE; 28 const GURL& url) const OVERRIDE;
29 virtual content::WebUIController* CreateWebUIControllerForURL( 29 virtual content::WebUIController* CreateWebUIControllerForURL(
30 content::WebUI* web_ui, 30 content::WebUI* web_ui,
31 const GURL& url) const OVERRIDE; 31 const GURL& url) const OVERRIDE;
32 32
33 // Get the favicon for |page_url| and run |callback| with result when loaded. 33 // Get the favicon for |page_url| and run |callback| with result when loaded.
34 // Note. |callback| is always run asynchronously. 34 // Note. |callback| is always run asynchronously.
35 void GetFaviconForURL( 35 void GetFaviconForURL(
36 Profile* profile, 36 Profile* profile,
37 const GURL& page_url, 37 const GURL& page_url,
38 const std::vector<ui::ScaleFactor>& scale_factors, 38 const std::vector<ui::ScaleFactor>& scale_factors,
39 const FaviconService::FaviconResultsCallback& callback) const; 39 const favicon_base::FaviconResultsCallback& callback) const;
40 40
41 static ChromeWebUIControllerFactory* GetInstance(); 41 static ChromeWebUIControllerFactory* GetInstance();
42 42
43 protected: 43 protected:
44 ChromeWebUIControllerFactory(); 44 ChromeWebUIControllerFactory();
45 virtual ~ChromeWebUIControllerFactory(); 45 virtual ~ChromeWebUIControllerFactory();
46 46
47 private: 47 private:
48 friend struct DefaultSingletonTraits<ChromeWebUIControllerFactory>; 48 friend struct DefaultSingletonTraits<ChromeWebUIControllerFactory>;
49 49
50 // Gets the data for the favicon for a WebUI page. Returns NULL if the WebUI 50 // Gets the data for the favicon for a WebUI page. Returns NULL if the WebUI
51 // does not have a favicon. 51 // does not have a favicon.
52 // The returned favicon data must be 52 // The returned favicon data must be
53 // |gfx::kFaviconSize| x |gfx::kFaviconSize| DIP. GetFaviconForURL() should 53 // |gfx::kFaviconSize| x |gfx::kFaviconSize| DIP. GetFaviconForURL() should
54 // be updated if this changes. 54 // be updated if this changes.
55 base::RefCountedMemory* GetFaviconResourceBytes( 55 base::RefCountedMemory* GetFaviconResourceBytes(
56 const GURL& page_url, ui::ScaleFactor scale_factor) const; 56 const GURL& page_url, ui::ScaleFactor scale_factor) const;
57 57
58 DISALLOW_COPY_AND_ASSIGN(ChromeWebUIControllerFactory); 58 DISALLOW_COPY_AND_ASSIGN(ChromeWebUIControllerFactory);
59 }; 59 };
60 60
61 #endif // CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_ 61 #endif // CHROME_BROWSER_UI_WEBUI_CHROME_WEB_UI_CONTROLLER_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698