Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/bookmarks/chrome_bookmark_client.cc

Issue 291643002: Move favicon callbacks to favicon_base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/chrome_bookmark_client.h" 5 #include "chrome/browser/bookmarks/chrome_bookmark_client.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/favicon/favicon_changed_details.h" 9 #include "chrome/browser/favicon/favicon_changed_details.h"
10 #include "chrome/browser/favicon/favicon_service.h" 10 #include "chrome/browser/favicon/favicon_service.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 return false; 53 return false;
54 #else 54 #else
55 return true; 55 return true;
56 #endif 56 #endif
57 } 57 }
58 58
59 base::CancelableTaskTracker::TaskId ChromeBookmarkClient::GetFaviconImageForURL( 59 base::CancelableTaskTracker::TaskId ChromeBookmarkClient::GetFaviconImageForURL(
60 const GURL& page_url, 60 const GURL& page_url,
61 int icon_types, 61 int icon_types,
62 int desired_size_in_dip, 62 int desired_size_in_dip,
63 const FaviconImageCallback& callback, 63 const favicon_base::FaviconImageCallback& callback,
64 base::CancelableTaskTracker* tracker) { 64 base::CancelableTaskTracker* tracker) {
65 FaviconService* favicon_service = 65 FaviconService* favicon_service =
66 FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS); 66 FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
67 if (!favicon_service) 67 if (!favicon_service)
68 return base::CancelableTaskTracker::kBadTaskId; 68 return base::CancelableTaskTracker::kBadTaskId;
69 return favicon_service->GetFaviconImageForURL( 69 return favicon_service->GetFaviconImageForURL(
70 FaviconService::FaviconForURLParams( 70 FaviconService::FaviconForURLParams(
71 page_url, icon_types, desired_size_in_dip), 71 page_url, icon_types, desired_size_in_dip),
72 callback, 72 callback,
73 tracker); 73 tracker);
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 const BookmarkNode* node, 145 const BookmarkNode* node,
146 const std::set<GURL>& removed_urls) { 146 const std::set<GURL>& removed_urls) {
147 NotifyHistoryOfRemovedURLs(profile_, removed_urls); 147 NotifyHistoryOfRemovedURLs(profile_, removed_urls);
148 } 148 }
149 149
150 void ChromeBookmarkClient::BookmarkAllNodesRemoved( 150 void ChromeBookmarkClient::BookmarkAllNodesRemoved(
151 BookmarkModel* model, 151 BookmarkModel* model,
152 const std::set<GURL>& removed_urls) { 152 const std::set<GURL>& removed_urls) {
153 NotifyHistoryOfRemovedURLs(profile_, removed_urls); 153 NotifyHistoryOfRemovedURLs(profile_, removed_urls);
154 } 154 }
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/chrome_bookmark_client.h ('k') | chrome/browser/extensions/extension_web_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698