chrome/browser/favicon/favicon_tab_helper.cc - Issue 291643002: Move favicon callbacks to favicon_base

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 291643002: Move favicon callbacks to favicon_base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix to comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/favicon/favicon_service.cc ('k') | chrome/browser/history/android/sqlite_cursor.h » ('j') | components/favicon_base/favicon_callback.h » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/favicon/favicon_tab_helper.h"	5 #include "chrome/browser/favicon/favicon_tab_helper.h"

6	6

7 #include "chrome/browser/bookmarks/bookmark_model_factory.h"	7 #include "chrome/browser/bookmarks/bookmark_model_factory.h"

8 #include "chrome/browser/chrome_notification_types.h"	8 #include "chrome/browser/chrome_notification_types.h"

9 #include "chrome/browser/favicon/favicon_handler.h"	9 #include "chrome/browser/favicon/favicon_handler.h"

	10 #include "chrome/browser/favicon/favicon_service.h"

10 #include "chrome/browser/favicon/favicon_service_factory.h"	11 #include "chrome/browser/favicon/favicon_service_factory.h"

11 #include "chrome/browser/favicon/favicon_util.h"	12 #include "chrome/browser/favicon/favicon_util.h"

12 #include "chrome/browser/history/history_service.h"	13 #include "chrome/browser/history/history_service.h"

13 #include "chrome/browser/history/history_service_factory.h"	14 #include "chrome/browser/history/history_service_factory.h"

14 #include "chrome/browser/profiles/profile.h"	15 #include "chrome/browser/profiles/profile.h"

15 #include "chrome/browser/search/search.h"	16 #include "chrome/browser/search/search.h"

16 #include "chrome/common/chrome_constants.h"	17 #include "chrome/common/chrome_constants.h"

17 #include "chrome/common/url_constants.h"	18 #include "chrome/common/url_constants.h"

18 #include "components/bookmarks/core/browser/bookmark_model.h"	19 #include "components/bookmarks/core/browser/bookmark_model.h"

19 #include "components/favicon_base/favicon_types.h"	20 #include "components/favicon_base/favicon_types.h"

(...skipping 265 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
285 favicon_service->UnableToDownloadFavicon(image_url);	286 favicon_service->UnableToDownloadFavicon(image_url);

286 }	287 }

287	288

288 favicon_handler_->OnDidDownloadFavicon(	289 favicon_handler_->OnDidDownloadFavicon(

289 id, image_url, bitmaps, original_bitmap_sizes);	290 id, image_url, bitmaps, original_bitmap_sizes);

290 if (touch_icon_handler_.get()) {	291 if (touch_icon_handler_.get()) {

291 touch_icon_handler_->OnDidDownloadFavicon(	292 touch_icon_handler_->OnDidDownloadFavicon(

292 id, image_url, bitmaps, original_bitmap_sizes);	293 id, image_url, bitmaps, original_bitmap_sizes);

293 }	294 }

294 }	295 }

OLD	NEW