Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2916393002: Compute constants from IR nodes (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute constants from IR nodes + skip generateCodeWithCompileTimeErrors: KernelAstAdapter cannot handle all ConstantExpression for erroneous code + allow runtime-error in language/final_syntax_test/none: Constantifier currently don's support non-cyclic reference of final fields as constant expressions R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/872a50cc2fa26afad96815a77cce1795213e5d5b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -121 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 18 chunks +102 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 9 chunks +18 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 3 chunks +10 lines, -46 lines 0 comments Download
M tests/language/language_dart2js.status View 6 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-02 19:10:44 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2916393002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart File pkg/compiler/lib/src/ssa/builder_kernel.dart (right): https://codereview.chromium.org/2916393002/diff/1/pkg/compiler/lib/src/ssa/builder_kernel.dart#newcode2005 pkg/compiler/lib/src/ssa/builder_kernel.dart:2005: print('$staticGet'); delete?
3 years, 6 months ago (2017-06-02 19:26:03 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-02 20:04:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
872a50cc2fa26afad96815a77cce1795213e5d5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698