Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2219)

Unified Diff: chrome/browser/notifications/native_notification_delegate.h

Issue 2916383004: Revert of Minimize the delegate dependencies for non persistent notifications. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/native_notification_delegate.h
diff --git a/chrome/browser/notifications/native_notification_delegate.h b/chrome/browser/notifications/native_notification_delegate.h
deleted file mode 100644
index 1bbdd985d4ba0be6729f53f201b024cc3c3d07c0..0000000000000000000000000000000000000000
--- a/chrome/browser/notifications/native_notification_delegate.h
+++ /dev/null
@@ -1,30 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_NOTIFICATIONS_NATIVE_NOTIFICATION_DELEGATE_H_
-#define CHROME_BROWSER_NOTIFICATIONS_NATIVE_NOTIFICATION_DELEGATE_H_
-
-#include "chrome/browser/notifications/notification_delegate.h"
-
-// Temporary native notification delegate, it is only used
-// to extract the delegate id.
-// This is an interim state until the work in
-// https://bugs.chromium.org/p/chromium/issues/detail?id=720345
-// is completed. A small delegate shim is needed since the
-// Notification object has a non virtual method (delegate_id) that is
-// used all over the place whose implementation returns delegate->id()
-class NativeNotificationDelegate : public NotificationDelegate {
- public:
- explicit NativeNotificationDelegate(const std::string& notification_id)
- : notification_id_(notification_id) {}
- std::string id() const override;
-
- private:
- ~NativeNotificationDelegate() override = default;
- const std::string notification_id_;
-
- DISALLOW_COPY_AND_ASSIGN(NativeNotificationDelegate);
-};
-
-#endif // CHROME_BROWSER_NOTIFICATIONS_NATIVE_NOTIFICATION_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698