Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2916383003: Implement getInterfaceMember() for IncrementalClassHierarchy. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -14 lines) Patch
M pkg/kernel/lib/src/incremental_class_hierarchy.dart View 1 7 chunks +118 lines, -4 lines 2 comments Download
M pkg/kernel/test/class_hierarchy_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 6 months ago (2017-06-02 21:56:47 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2916383003/diff/20001/pkg/kernel/lib/src/incremental_class_hierarchy.dart File pkg/kernel/lib/src/incremental_class_hierarchy.dart (right): https://codereview.chromium.org/2916383003/diff/20001/pkg/kernel/lib/src/incremental_class_hierarchy.dart#newcode442 pkg/kernel/lib/src/incremental_class_hierarchy.dart:442: List<Member> result = <Member>[]..length = inherited.length; Creating the ...
3 years, 6 months ago (2017-06-03 13:27:34 UTC) #2
scheglov
https://codereview.chromium.org/2916383003/diff/20001/pkg/kernel/lib/src/incremental_class_hierarchy.dart File pkg/kernel/lib/src/incremental_class_hierarchy.dart (right): https://codereview.chromium.org/2916383003/diff/20001/pkg/kernel/lib/src/incremental_class_hierarchy.dart#newcode442 pkg/kernel/lib/src/incremental_class_hierarchy.dart:442: List<Member> result = <Member>[]..length = inherited.length; On 2017/06/03 13:27:34, ...
3 years, 6 months ago (2017-06-04 00:47:47 UTC) #3
scheglov
3 years, 6 months ago (2017-06-04 01:52:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5cf61cb0dc846405e71e7ac270615070e14f36c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698