Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2916353002: Support locals in compile_from_dill_test. (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 3 chunks +30 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-02 18:15:13 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
3 years, 6 months ago (2017-06-02 18:20:38 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-02 19:15:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed01aef046b99d7c44064fbf74a65d8206f5dc9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698