Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2916333002: Setup correct scope for initializers and complain about fields initialized more than once. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Setup correct scope for initializers and complain about fields initialized more than once. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/470127ae46ca783f7d625010c028073464cdb179

Patch Set 1 #

Patch Set 2 : Fix for incorrect offset. #

Patch Set 3 : A parenthesized expression doesn't have a name. #

Total comments: 7

Patch Set 4 : Address review comments. #

Patch Set 5 : More typos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -153 lines) Patch
M pkg/front_end/lib/src/fasta/builder/field_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/formal_parameter_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/procedure_builder.dart View 2 chunks +31 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 3 13 chunks +133 lines, -83 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 1 2 3 4 8 chunks +22 lines, -17 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 1 2 3 4 chunks +28 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 4 chunks +11 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 2 3 2 chunks +17 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +8 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/unhandled_listener.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/co19/co19-kernel.status View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language_kernel.status View 7 chunks +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
ahe
3 years, 6 months ago (2017-06-02 17:18:08 UTC) #4
ahe
Note: I uploaded a new patch set to deal with a failing debugger test.
3 years, 6 months ago (2017-06-02 17:37:24 UTC) #5
Paul Berry
I don't feel knowledgeable enough about the outline builder logic to review this.
3 years, 6 months ago (2017-06-03 13:43:51 UTC) #6
ahe
New patch set. https://codereview.chromium.org/2916333002/diff/80001/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart File pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart (right): https://codereview.chromium.org/2916333002/diff/80001/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart#newcode821 pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart:821: : super(helper, expression, null, token); This ...
3 years, 6 months ago (2017-06-06 09:32:34 UTC) #7
Johnni Winther
lgtm https://codereview.chromium.org/2916333002/diff/80001/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2916333002/diff/80001/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode2695 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2695: Initializer initializer = buildInvalidIntializer( buildInvalidIntializer -> buildInvalidInitializer https://codereview.chromium.org/2916333002/diff/80001/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart ...
3 years, 6 months ago (2017-06-06 10:35:08 UTC) #8
ahe
Thank you!
3 years, 6 months ago (2017-06-06 15:07:28 UTC) #9
ahe
https://codereview.chromium.org/2916333002/diff/80001/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2916333002/diff/80001/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode2695 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2695: Initializer initializer = buildInvalidIntializer( On 2017/06/06 10:35:08, Johnni Winther ...
3 years, 6 months ago (2017-06-06 15:08:24 UTC) #10
ahe
3 years, 6 months ago (2017-06-06 17:35:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:140001) manually as
470127ae46ca783f7d625010c028073464cdb179 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698