Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: content/public/browser/content_browser_client.h

Issue 2916323004: Expose GetLoggingFileName in ContentBrowserClient. (Closed)
Patch Set: Simplify API Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 const GURL& new_url); 301 const GURL& new_url);
302 302
303 // Returns true if the passed in URL should be assigned as the site of the 303 // Returns true if the passed in URL should be assigned as the site of the
304 // current SiteInstance, if it does not yet have a site. 304 // current SiteInstance, if it does not yet have a site.
305 virtual bool ShouldAssignSiteForURL(const GURL& url); 305 virtual bool ShouldAssignSiteForURL(const GURL& url);
306 306
307 // Allows the embedder to pass extra command line flags. 307 // Allows the embedder to pass extra command line flags.
308 // switches::kProcessType will already be set at this point. 308 // switches::kProcessType will already be set at this point.
309 virtual void AppendExtraCommandLineSwitches(base::CommandLine* command_line, 309 virtual void AppendExtraCommandLineSwitches(base::CommandLine* command_line,
310 int child_process_id) {} 310 int child_process_id) {}
311 311
Robert Sesek 2017/06/05 15:20:30 Here may be a better place to put the method, rath
Greg K 2017/06/05 19:03:31 Done.
312 // Returns the locale used by the application. 312 // Returns the locale used by the application.
313 // This is called on the UI and IO threads. 313 // This is called on the UI and IO threads.
314 virtual std::string GetApplicationLocale(); 314 virtual std::string GetApplicationLocale();
315 315
316 // Returns the languages used in the Accept-Languages HTTP header. 316 // Returns the languages used in the Accept-Languages HTTP header.
317 // (Not called GetAcceptLanguages so it doesn't clash with win32). 317 // (Not called GetAcceptLanguages so it doesn't clash with win32).
318 virtual std::string GetAcceptLangs(BrowserContext* context); 318 virtual std::string GetAcceptLangs(BrowserContext* context);
319 319
320 // Returns the default favicon. The callee doesn't own the given bitmap. 320 // Returns the default favicon. The callee doesn't own the given bitmap.
321 virtual const gfx::ImageSkia* GetDefaultFavicon(); 321 virtual const gfx::ImageSkia* GetDefaultFavicon();
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 // Performs any necessary PostTask API redirection to the task scheduler. 808 // Performs any necessary PostTask API redirection to the task scheduler.
809 virtual void PerformExperimentalTaskSchedulerRedirections() {} 809 virtual void PerformExperimentalTaskSchedulerRedirections() {}
810 810
811 // Returns true if the DOMStorageTaskRunner should be redirected to the task 811 // Returns true if the DOMStorageTaskRunner should be redirected to the task
812 // scheduler. 812 // scheduler.
813 virtual bool ShouldRedirectDOMStorageTaskRunner(); 813 virtual bool ShouldRedirectDOMStorageTaskRunner();
814 814
815 // If this returns true, all BrowserThreads (but UI/IO) that support it on 815 // If this returns true, all BrowserThreads (but UI/IO) that support it on
816 // this platform will experimentally be redirected to TaskScheduler. 816 // this platform will experimentally be redirected to TaskScheduler.
817 virtual bool RedirectNonUINonIOBrowserThreadsToTaskScheduler(); 817 virtual bool RedirectNonUINonIOBrowserThreadsToTaskScheduler();
818
819 // Returns the fully qualified path to the log file name, and returns whether
Robert Sesek 2017/06/05 15:20:30 It can't return both of these things.
Greg K 2017/06/05 19:03:31 Done.
820 // or not that succeeded.
821 virtual base::FilePath GetLoggingFileName();
818 }; 822 };
819 823
820 } // namespace content 824 } // namespace content
821 825
822 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 826 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698