Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2916273002: Clean up type inference for PropertySet. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up type inference for PropertySet. These changes are follow ups to cd5bacbc54b89d83ffd041aa76a81e0e62da42dd. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8ae9237efd3d43c1e2c4009011eb50510d28905b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 3 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-02 03:28:10 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-02 03:29:56 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-02 03:56:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ae9237efd3d43c1e2c4009011eb50510d28905b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698