Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2916223002: fix #29146, downgrade import error to warning in strong mode (Closed)

Created:
3 years, 6 months ago by Jennifer Messerly
Modified:
3 years, 6 months ago
Reviewers:
vsm, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #29146, downgrade import error to warning in strong mode R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/88510c18602ef9ea511d15a0d05484b47246dcfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
3 years, 6 months ago (2017-06-01 22:35:58 UTC) #2
Brian Wilkerson
lgtm
3 years, 6 months ago (2017-06-01 22:40:32 UTC) #3
Jennifer Messerly
3 years, 6 months ago (2017-06-01 22:44:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88510c18602ef9ea511d15a0d05484b47246dcfb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698