Issue 2916173002: Avoid allocating a whole new page for two one-element arrays when finalizing the VM isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2916173002: Avoid allocating a whole new page for two one-element arrays when finalizing the VM isolate. (Closed)

Created:
3 years, 6 months ago by rmacnak

Modified:
3 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, erikcorry

Target Ref:
refs/heads/master

Visibility:
Public.

Avoid allocating a whole new page for two one-element arrays when finalizing the VM isolate. Flush the bump allocation block to the free list after deserializing the VM isolate's snapshot, making this memory available to Array::New(n, Heap::kOld). R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/139cf6a8c177a075da4afff6388bd2822a1169d9

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	runtime/vm/clustered_snapshot.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	runtime/vm/pages.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

vm isolate heap.old.capacity 1.543 MB (1617920 B) => heap.old.capacity 1.293 MB (1355776 B)

3 years, 6 months ago (2017-06-01 21:37:58 UTC) #2

rmacnak

3 years, 6 months ago (2017-06-01 22:51:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
139cf6a8c177a075da4afff6388bd2822a1169d9 (presubmit successful).