Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4047)

Unified Diff: chrome/browser/media/router/media_router_metrics_unittest.cc

Issue 2916163002: [MediaRouter] Record DIAL device counts in DialMediaSinkServiceImpl (Closed)
Patch Set: resolve code review comments from isherman Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/router/media_router_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/media_router_metrics_unittest.cc
diff --git a/chrome/browser/media/router/media_router_metrics_unittest.cc b/chrome/browser/media/router/media_router_metrics_unittest.cc
index be1a5a9356de3a8424ce5bb9fd45d3dce850fb92..3269c51df5f0bfb507bd970907a4cebd994f30b0 100644
--- a/chrome/browser/media/router/media_router_metrics_unittest.cc
+++ b/chrome/browser/media/router/media_router_metrics_unittest.cc
@@ -2,11 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/media/router/media_router_metrics.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "base/test/histogram_tester.h"
+#include "base/test/simple_test_clock.h"
#include "base/time/time.h"
-#include "chrome/browser/media/router/media_router_metrics.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -93,4 +95,41 @@ TEST(MediaRouterMetricsTest, RecordRouteCreationOutcome) {
Bucket(static_cast<int>(outcome2), 2)));
}
+TEST(MediaRouterMetricsTest, RecordDialDeviceCounts) {
+ MediaRouterMetrics metrics;
+ base::SimpleTestClock* clock = new base::SimpleTestClock();
+ metrics.SetClockForTest(base::WrapUnique(clock));
+ base::HistogramTester tester;
+ tester.ExpectTotalCount(
+ MediaRouterMetrics::kHistogramDialAvailableDeviceCount, 0);
+ tester.ExpectTotalCount(MediaRouterMetrics::kHistogramDialKnownDeviceCount,
+ 0);
+
+ clock->SetNow(base::Time::Now());
+ metrics.RecordDialDeviceCounts(6, 10);
+ metrics.RecordDialDeviceCounts(7, 10);
+ tester.ExpectTotalCount(
+ MediaRouterMetrics::kHistogramDialAvailableDeviceCount, 1);
+ tester.ExpectTotalCount(MediaRouterMetrics::kHistogramDialKnownDeviceCount,
+ 1);
+ tester.ExpectBucketCount(
+ MediaRouterMetrics::kHistogramDialAvailableDeviceCount, 6, 1);
+ tester.ExpectBucketCount(MediaRouterMetrics::kHistogramDialKnownDeviceCount,
+ 10, 1);
+
+ clock->Advance(base::TimeDelta::FromHours(2));
+ metrics.RecordDialDeviceCounts(7, 10);
+
+ tester.ExpectTotalCount(
+ MediaRouterMetrics::kHistogramDialAvailableDeviceCount, 2);
+ tester.ExpectTotalCount(MediaRouterMetrics::kHistogramDialKnownDeviceCount,
+ 2);
+ tester.ExpectBucketCount(
+ MediaRouterMetrics::kHistogramDialAvailableDeviceCount, 6, 1);
+ tester.ExpectBucketCount(
+ MediaRouterMetrics::kHistogramDialAvailableDeviceCount, 7, 1);
+ tester.ExpectBucketCount(MediaRouterMetrics::kHistogramDialKnownDeviceCount,
+ 10, 2);
+}
+
} // namespace media_router
« no previous file with comments | « chrome/browser/media/router/media_router_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698