Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7510)

Unified Diff: chrome/browser/media/router/media_router_metrics.h

Issue 2916163002: [MediaRouter] Record DIAL device counts in DialMediaSinkServiceImpl (Closed)
Patch Set: resolve code review comments from isherman Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router_metrics.h
diff --git a/chrome/browser/media/router/media_router_metrics.h b/chrome/browser/media/router/media_router_metrics.h
index ce3e2d252136b7f20ad80a43ff428df0372fa5a7..0276e6f4ba5723f94d2e5e610c21993b4862f29b 100644
--- a/chrome/browser/media/router/media_router_metrics.h
+++ b/chrome/browser/media/router/media_router_metrics.h
@@ -5,7 +5,10 @@
#ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_METRICS_H_
#define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_METRICS_H_
+#include <memory>
+
#include "base/gtest_prod_util.h"
+#include "base/time/clock.h"
#include "base/time/time.h"
namespace media_router {
@@ -54,7 +57,12 @@ enum class MediaRouterUserAction {
class MediaRouterMetrics {
public:
+ MediaRouterMetrics();
+ ~MediaRouterMetrics();
+
// UMA histogram names.
+ static const char kHistogramDialAvailableDeviceCount[];
+ static const char kHistogramDialKnownDeviceCount[];
static const char kHistogramIconClickLocation[];
static const char kHistogramUiDialogPaint[];
static const char kHistogramUiDialogLoadedWithData[];
@@ -83,6 +91,20 @@ class MediaRouterMetrics {
// Records the outcome in a create route response.
static void RecordRouteCreationOutcome(
MediaRouterRouteCreationOutcome outcome);
+
+ // Records device counts.
+ // TODO(zhaobin): Move device count specific metrics and state into its own
+ // class eventually.
+ void RecordDialDeviceCounts(size_t available_device_count,
+ size_t known_device_count);
+
+ // Allows tests to swap in a fake clock.
+ void SetClockForTest(std::unique_ptr<base::Clock> clock);
+
+ private:
+ base::Time device_count_metrics_record_time_;
+
+ std::unique_ptr<base::Clock> clock_;
};
} // namespace media_router
« no previous file with comments | « chrome/browser/media/router/discovery/media_sink_service_base.cc ('k') | chrome/browser/media/router/media_router_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698