chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc - Issue 2916163002: [MediaRouter] Record DIAL device counts in DialMediaSinkServiceImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc

Issue 2916163002: [MediaRouter] Record DIAL device counts in DialMediaSinkServiceImpl (Closed)

Patch Set: resolve code review comments from isherman Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h ('k') | chrome/browser/media/router/discovery/media_sink_service_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc

diff --git a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc

index cf8b03d66b609d691a40aac38f5b070249f14741..a87915701ffe68483d1fd043e18e62a2a9525961 100644

--- a/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc

+++ b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc

@@ -129,4 +129,9 @@ void DialMediaSinkServiceImpl::OnDeviceDescriptionError(

DVLOG(2) << "OnDescriptionFetchesError [message]: " << error_message;

}

+void DialMediaSinkServiceImpl::RecordDeviceCounts() {

+ metrics_.RecordDialDeviceCounts(current_sinks_.size(),

+ current_devices_.size());

} // namespace media_router