Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2916163002: [MediaRouter] Record DIAL device counts in DialMediaSinkServiceImpl (Closed)
Patch Set: resolve code review comments from Mark Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/browser/media/router/media_router_metrics.cc ('K') | « chrome/browser/media/router/media_router_metrics_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ceeaeb1296fa0931d58c0fbbd244f8711f49ffe2..e778caeb27b7f42de141bdb1e52f88efc5478ea1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -30116,6 +30116,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Various usage counts for media galleries.</summary>
</histogram>
+<histogram name="MediaRouter.Dial.AvailableDevicesCount">
Ilya Sherman 2017/06/07 04:57:03 nit: Please add units="devices"
zhaobin 2017/06/07 20:45:56 Done.
+ <owner>zhaobin@chromium.org</owner>
+ <summary>The number of available DIAL devices.</summary>
Ilya Sherman 2017/06/07 04:57:03 Please document when this is recorded.
zhaobin 2017/06/07 20:45:56 Done.
+</histogram>
+
+<histogram name="MediaRouter.Dial.KnownDevicesCount">
Ilya Sherman 2017/06/07 04:57:03 nit: Please add units="devices"
zhaobin 2017/06/07 20:45:56 Done.
+ <owner>zhaobin@chromium.org</owner>
+ <summary>The number of known DIAL devices.</summary>
Ilya Sherman 2017/06/07 04:57:03 Ditto
zhaobin 2017/06/07 20:45:56 Done.
+</histogram>
+
<histogram name="MediaRouter.Icon.Click.Location"
enum="MediaRouterDialogOpenOrigin">
<owner>apacible@chromium.org</owner>
« chrome/browser/media/router/media_router_metrics.cc ('K') | « chrome/browser/media/router/media_router_metrics_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698