Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: components/sync/engine_impl/non_blocking_type_commit_contribution.h

Issue 2916133002: [Sync] Support commit only types. (Closed)
Patch Set: Rebase again. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/non_blocking_type_commit_contribution.h
diff --git a/components/sync/engine_impl/non_blocking_type_commit_contribution.h b/components/sync/engine_impl/non_blocking_type_commit_contribution.h
index 39d1f50158abf5fca7c939a6a8b3146b701bbb51..1f5aee8f3995f8e6568d01c3039d5796e3969a21 100644
--- a/components/sync/engine_impl/non_blocking_type_commit_contribution.h
+++ b/components/sync/engine_impl/non_blocking_type_commit_contribution.h
@@ -29,7 +29,8 @@ class NonBlockingTypeCommitContribution : public CommitContribution {
const sync_pb::DataTypeContext& context,
const google::protobuf::RepeatedPtrField<sync_pb::SyncEntity>& entities,
ModelTypeWorker* worker,
- DataTypeDebugInfoEmitter* debug_info_emitter);
+ DataTypeDebugInfoEmitter* debug_info_emitter,
+ bool clear_client_defined_unique_tags);
~NonBlockingTypeCommitContribution() override;
// Implementation of CommitContribution
@@ -60,6 +61,13 @@ class NonBlockingTypeCommitContribution : public CommitContribution {
DataTypeDebugInfoEmitter* debug_info_emitter_;
+ // If we should remove all the tag hashes from the commit data that actually
+ // gets sent over the wire. This is used to save bandwidth when we do not need
+ // these entities to have consistent client ids, such as with commit only
+ // types. These ids are still passed into this contribution object so that
+ // they can be set on response before handing back to the |worker_|.
+ bool clear_client_defined_unique_tags_;
+
DISALLOW_COPY_AND_ASSIGN(NonBlockingTypeCommitContribution);
};

Powered by Google App Engine
This is Rietveld 408576698